feat: 重构注单控制器以复用共享筛选逻辑

新增 TicketItemListFilters trait,用于封装注单列表的通用筛选逻辑。
更新 AdminPlayerTicketItemsIndexController、AdminTicketItemIndexController 与 TicketItemsIndexController,统一使用新的注单编号搜索与订单日期范围筛选方法,提升代码复用性与可读性。
增强 AdminRiskPoolManualStatusController:支持发布手动停售状态变更通知。
优化 RiskPoolService 与 TicketWalletService:钱包资金变动后实时通知余额更新。
更新测试用例,确保重构后功能行为保持一致。
This commit is contained in:
2026-05-26 17:14:19 +08:00
parent 36e50383ba
commit 618201f980
12 changed files with 408 additions and 84 deletions

View File

@@ -5,8 +5,9 @@ namespace App\Http\Controllers\Api\V1\Admin\Player;
use App\Models\Player;
use App\Models\TicketItem;
use App\Support\ApiResponse;
use App\Support\PaginationTrait;
use App\Support\CurrencyFormatter;
use App\Support\PaginationTrait;
use App\Support\TicketItemListFilters;
use Illuminate\Http\JsonResponse;
use App\Http\Controllers\Controller;
use App\Http\Requests\Admin\AdminPlayerTicketItemsRequest;
@@ -19,6 +20,7 @@ use App\Http\Requests\Admin\AdminPlayerTicketItemsRequest;
final class AdminPlayerTicketItemsIndexController extends Controller
{
use PaginationTrait;
use TicketItemListFilters;
public function __invoke(AdminPlayerTicketItemsRequest $request, Player $player): JsonResponse
{
@@ -56,22 +58,8 @@ final class AdminPlayerTicketItemsIndexController extends Controller
$query->whereIn('ticket_items.status', $statusValues);
}
if ($number !== '') {
$query->where(function ($q) use ($number): void {
$q->where('ticket_items.original_number', 'like', '%'.$number.'%')
->orWhere('ticket_items.normalized_number', 'like', '%'.$number.'%')
->orWhere('ticket_items.ticket_no', 'like', '%'.$number.'%')
->orWhereHas('order', fn ($order) => $order->where('order_no', 'like', '%'.$number.'%'));
});
}
if (is_string($startDate) && $startDate !== '') {
$query->whereHas('order', fn ($q) => $q->whereDate('created_at', '>=', $startDate));
}
if (is_string($endDate) && $endDate !== '') {
$query->whereHas('order', fn ($q) => $q->whereDate('created_at', '<=', $endDate));
}
$this->applyTicketItemNumberSearch($query, $number);
$this->applyOrderPlacedDateRange($query, $startDate, $endDate);
$paginator = $query->paginate(perPage: $perPage, page: $page, columns: ['*']);

View File

@@ -66,12 +66,17 @@ final class AdminRiskPoolManualStatusController extends Controller
}
$targetStatus = $soldOut ? 1 : 0;
if ((int) $pool->sold_out_status !== $targetStatus) {
$soldOutBefore = (int) $pool->sold_out_status;
if ($soldOutBefore !== $targetStatus) {
$pool->forceFill([
'sold_out_status' => $targetStatus,
'version' => (int) $pool->version + 1,
])->save();
if ($targetStatus === 1) {
$this->riskPoolService->publishManualSoldOut($draw, $number4d);
}
RiskPoolLockLog::query()->create([
'draw_id' => $draw->id,
'normalized_number' => $number4d,

View File

@@ -8,6 +8,7 @@ use App\Models\TicketItem;
use App\Support\ApiResponse;
use App\Support\CurrencyFormatter;
use App\Support\PaginationTrait;
use App\Support\TicketItemListFilters;
use Illuminate\Http\JsonResponse;
/**
@@ -25,6 +26,7 @@ use Illuminate\Http\JsonResponse;
final class AdminTicketItemIndexController extends Controller
{
use PaginationTrait;
use TicketItemListFilters;
public function __invoke(TicketItemListRequest $request): JsonResponse
{
@@ -72,24 +74,12 @@ final class AdminTicketItemIndexController extends Controller
}
$number = trim((string) ($validated['number'] ?? ''));
if ($number !== '') {
$query->where(function ($q) use ($number): void {
$q->where('ticket_items.original_number', 'like', '%'.$number.'%')
->orWhere('ticket_items.normalized_number', 'like', '%'.$number.'%')
->orWhere('ticket_items.ticket_no', 'like', '%'.$number.'%')
->orWhereHas('order', fn ($order) => $order->where('order_no', 'like', '%'.$number.'%'));
});
}
$startDate = $validated['start_date'] ?? null;
if (is_string($startDate) && $startDate !== '') {
$query->whereHas('order', fn ($q) => $q->whereDate('created_at', '>=', $startDate));
}
$endDate = $validated['end_date'] ?? null;
if (is_string($endDate) && $endDate !== '') {
$query->whereHas('order', fn ($q) => $q->whereDate('created_at', '<=', $endDate));
}
$this->applyTicketItemNumberSearch($query, $number);
$this->applyOrderPlacedDateRange(
$query,
is_string($validated['start_date'] ?? null) ? $validated['start_date'] : null,
is_string($validated['end_date'] ?? null) ? $validated['end_date'] : null,
);
$paginator = $query->paginate(perPage: $perPage, page: $page, columns: ['*']);

View File

@@ -2,10 +2,10 @@
namespace App\Http\Controllers\Api\V1\Ticket;
use Carbon\Carbon;
use App\Models\Player;
use App\Models\TicketItem;
use App\Support\ApiResponse;
use App\Support\TicketItemListFilters;
use Illuminate\Http\Request;
use App\Support\PaginationTrait;
use Illuminate\Http\JsonResponse;
@@ -18,6 +18,7 @@ use App\Http\Controllers\Controller;
final class TicketItemsIndexController extends Controller
{
use PaginationTrait;
use TicketItemListFilters;
public function __invoke(Request $request): JsonResponse
{
@@ -56,23 +57,8 @@ final class TicketItemsIndexController extends Controller
$query->whereIn('ticket_items.status', $statusValues);
}
if ($number !== '') {
$query->where(function ($q) use ($number): void {
$q->where('ticket_items.original_number', 'like', '%'.$number.'%')
->orWhere('ticket_items.normalized_number', 'like', '%'.$number.'%')
->orWhere('ticket_items.ticket_no', 'like', '%'.$number.'%');
});
}
if ($startDate !== null) {
$fromUtc = $this->scheduleDateStartUtc($startDate);
$query->whereHas('order', fn ($q) => $q->where('created_at', '>=', $fromUtc));
}
if ($endDate !== null) {
$toUtc = $this->scheduleDateEndUtc($endDate);
$query->whereHas('order', fn ($q) => $q->where('created_at', '<=', $toUtc));
}
$this->applyTicketItemNumberSearch($query, $number);
$this->applyOrderPlacedDateRange($query, $startDate, $endDate);
$paginator = $query->paginate(perPage: $perPage, page: $page);
@@ -122,23 +108,4 @@ final class TicketItemsIndexController extends Controller
return $value;
}
private function scheduleTimezone(): string
{
return (string) config('lottery.draw.timezone', 'UTC');
}
private function scheduleDateStartUtc(string $ymd): Carbon
{
return Carbon::createFromFormat('Y-m-d', $ymd, $this->scheduleTimezone())
->startOfDay()
->utc();
}
private function scheduleDateEndUtc(string $ymd): Carbon
{
return Carbon::createFromFormat('Y-m-d', $ymd, $this->scheduleTimezone())
->endOfDay()
->utc();
}
}

View File

@@ -0,0 +1,79 @@
<?php
namespace App\Services\Ticket;
use App\Models\Draw;
use App\Models\RiskPool;
use App\Services\Draw\LotteryHallRealtimeBroadcaster;
/**
* 风险池占用变化后推送 `risk.warning` / `risk.sold_out`(频道 `lottery-hall`)。
*/
final class RiskPoolRealtimePublisher
{
private const WARNING_RATIO = 0.8;
/** @var array<int, string> */
private array $drawNoById = [];
public function __construct(
private readonly LotteryHallRealtimeBroadcaster $hallRealtime,
) {}
public function publishAfterLock(
int $drawId,
string $normalizedNumber,
int $soldOutStatusBefore,
int $lockedAmountBefore,
int $totalCapBefore,
RiskPool $poolAfter,
): void {
$drawNo = $this->resolveDrawNo($drawId);
$normalizedNumber = strtoupper(trim($normalizedNumber));
$totalCap = (int) $poolAfter->total_cap_amount;
if ($totalCap < 1) {
$totalCap = max(1, $totalCapBefore);
}
$soldOutAfter = (int) $poolAfter->sold_out_status;
if ($soldOutAfter === 1 && $soldOutStatusBefore !== 1) {
$this->hallRealtime->notifyRiskSoldOut($drawId, $drawNo, $normalizedNumber);
}
$lockedAfter = (int) $poolAfter->locked_amount;
$usageBefore = $totalCapBefore > 0 ? $lockedAmountBefore / $totalCapBefore : 0.0;
$usageAfter = $totalCap > 0 ? $lockedAfter / $totalCap : 1.0;
if ($usageAfter >= self::WARNING_RATIO && $usageBefore < self::WARNING_RATIO) {
$this->hallRealtime->notifyRiskWarning(
$drawId,
$drawNo,
$normalizedNumber,
$usageAfter,
);
}
}
public function publishManualSoldOut(Draw $draw, string $normalizedNumber): void
{
$this->hallRealtime->notifyRiskSoldOut(
(int) $draw->id,
(string) $draw->draw_no,
strtoupper(trim($normalizedNumber)),
);
}
private function resolveDrawNo(int $drawId): string
{
if (isset($this->drawNoById[$drawId])) {
return $this->drawNoById[$drawId];
}
$drawNo = Draw::query()->whereKey($drawId)->value('draw_no');
$resolved = is_string($drawNo) && $drawNo !== '' ? $drawNo : (string) $drawId;
$this->drawNoById[$drawId] = $resolved;
return $resolved;
}
}

View File

@@ -2,6 +2,7 @@
namespace App\Services\Ticket;
use App\Models\Draw;
use App\Models\RiskPool;
use App\Lottery\ErrorCode;
use App\Models\TicketItem;
@@ -14,6 +15,7 @@ final class RiskPoolService
{
public function __construct(
private readonly PlayCatalogResolver $catalogResolver,
private readonly RiskPoolRealtimePublisher $riskRealtime,
) {}
/**
@@ -90,6 +92,10 @@ final class RiskPoolService
throw new TicketOperationException('risk_sold_out', ErrorCode::RiskPoolSoldOut->value);
}
$soldOutBefore = (int) $pool->sold_out_status;
$lockedBefore = (int) $pool->locked_amount;
$totalBefore = (int) $pool->total_cap_amount;
$pool->forceFill([
'locked_amount' => (int) $pool->locked_amount + $amount,
'remaining_amount' => (int) $pool->remaining_amount - $amount,
@@ -97,6 +103,15 @@ final class RiskPoolService
'version' => (int) $pool->version + 1,
])->save();
$this->riskRealtime->publishAfterLock(
$drawId,
$lock['number_4d'],
$soldOutBefore,
$lockedBefore,
$totalBefore,
$pool,
);
RiskPoolLockLog::query()->create([
'draw_id' => $drawId,
'normalized_number' => $lock['number_4d'],
@@ -172,6 +187,11 @@ final class RiskPoolService
}
}
public function publishManualSoldOut(Draw $draw, string $normalizedNumber): void
{
$this->riskRealtime->publishManualSoldOut($draw, $normalizedNumber);
}
/** 后台改池或释池后,将 Redis 风控快照与 DB 对齐。 */
public function syncRedisStateFromPool(RiskPool $pool): void
{
@@ -279,6 +299,10 @@ LUA;
throw new TicketOperationException('risk_sold_out', ErrorCode::RiskPoolSoldOut->value);
}
$soldOutBefore = (int) $pool->sold_out_status;
$lockedBefore = (int) $pool->locked_amount;
$totalBefore = (int) $pool->total_cap_amount;
$pool->forceFill([
'locked_amount' => (int) $pool->locked_amount + $amount,
'remaining_amount' => (int) $pool->remaining_amount - $amount,
@@ -286,6 +310,15 @@ LUA;
'version' => (int) $pool->version + 1,
])->save();
$this->riskRealtime->publishAfterLock(
$drawId,
$number4d,
$soldOutBefore,
$lockedBefore,
$totalBefore,
$pool,
);
RiskPoolLockLog::query()->create([
'draw_id' => $drawId,
'normalized_number' => $number4d,

View File

@@ -8,9 +8,13 @@ use App\Lottery\ErrorCode;
use App\Models\TicketOrder;
use App\Models\PlayerWallet;
use App\Exceptions\TicketOperationException;
use App\Services\Wallet\WalletBalanceRealtimeNotifier;
final class TicketWalletService
{
public function __construct(
private readonly WalletBalanceRealtimeNotifier $balanceRealtime,
) {}
private const TXN_POSTED = 'posted';
private const TXN_DIR_OUT = 2;
@@ -71,6 +75,9 @@ final class TicketWalletService
'remark' => null,
]);
$wallet->refresh();
$this->balanceRealtime->notifyAfterMovement($wallet, -$amountMinor, 'bet_deduct');
return $after;
}
@@ -119,6 +126,9 @@ final class TicketWalletService
'idempotent_key' => $idempotentKey,
'remark' => 'post_deduct_confirmation_failed',
]);
$wallet->refresh();
$this->balanceRealtime->notifyAfterMovement($wallet, $amount, 'bet_reverse');
}
/**
@@ -187,6 +197,9 @@ final class TicketWalletService
'idempotent_key' => $idempotentKey,
'remark' => 'manual_jackpot_burst',
]);
$wallet->refresh();
$this->balanceRealtime->notifyAfterMovement($wallet, $amountMinor, 'jackpot_manual_payout');
}
public function creditSettlementPayout(Player $player, string $currencyCode, int $amountMinor, int $settlementBatchId): void
@@ -243,6 +256,9 @@ final class TicketWalletService
'idempotent_key' => $idempotentKey,
'remark' => null,
]);
$wallet->refresh();
$this->balanceRealtime->notifyAfterMovement($wallet, $amountMinor, 'settle_payout');
}
private function newTxnNo(): string

View File

@@ -58,6 +58,7 @@ final class LotteryTransferService
public function __construct(
private readonly MainSiteWalletGateway $mainSite,
private readonly WalletBalanceRealtimeNotifier $balanceRealtime,
) {}
/**
@@ -841,6 +842,9 @@ final class LotteryTransferService
'remark' => $remark,
]);
$wallet->refresh();
$this->balanceRealtime->notifyAfterMovement($wallet, $delta, $bizType);
return [
'before' => $before,
'after' => $after,

View File

@@ -0,0 +1,51 @@
<?php
namespace App\Services\Wallet;
use App\Models\PlayerWallet;
use App\Services\PlayerRealtimeBroadcaster;
/**
* 钱包余额变动后推送 `balance.update`(频道 `player.{id}`)。
*/
final class WalletBalanceRealtimeNotifier
{
public function __construct(
private readonly PlayerRealtimeBroadcaster $playerRealtime,
) {}
public function notifyAfterMovement(
PlayerWallet $wallet,
int $changeMinor,
string $bizType,
): void {
if ($changeMinor === 0) {
return;
}
$reason = $this->mapBizTypeToReason($bizType);
if ($reason === null) {
return;
}
$this->playerRealtime->notifyBalanceUpdate(
(int) $wallet->player_id,
(string) $wallet->currency_code,
(int) $wallet->balance,
$changeMinor,
$reason,
);
}
private function mapBizTypeToReason(string $bizType): ?string
{
return match ($bizType) {
'transfer_in' => 'transfer_in',
'transfer_out' => 'transfer_out',
'transfer_out_refund', 'bet_reverse', 'reversal' => 'refund',
'bet_deduct' => 'bet',
'settle_payout', 'jackpot_manual_payout' => 'prize',
default => null,
};
}
}

View File

@@ -0,0 +1,59 @@
<?php
namespace App\Support;
use Carbon\Carbon;
use Illuminate\Database\Eloquent\Builder;
/**
* 注项列表共用筛选:号码/订单号搜索、按开奖时区日界筛选下单时间。
*/
trait TicketItemListFilters
{
protected function applyTicketItemNumberSearch(Builder $query, string $number): void
{
$number = trim($number);
if ($number === '') {
return;
}
$query->where(function (Builder $q) use ($number): void {
$q->where('ticket_items.original_number', 'like', '%'.$number.'%')
->orWhere('ticket_items.normalized_number', 'like', '%'.$number.'%')
->orWhere('ticket_items.ticket_no', 'like', '%'.$number.'%')
->orWhereHas('order', fn (Builder $order) => $order->where('order_no', 'like', '%'.$number.'%'));
});
}
protected function applyOrderPlacedDateRange(Builder $query, ?string $startDate, ?string $endDate): void
{
if (is_string($startDate) && $startDate !== '') {
$fromUtc = $this->scheduleDateStartUtc($startDate);
$query->whereHas('order', fn (Builder $q) => $q->where('created_at', '>=', $fromUtc));
}
if (is_string($endDate) && $endDate !== '') {
$toUtc = $this->scheduleDateEndUtc($endDate);
$query->whereHas('order', fn (Builder $q) => $q->where('created_at', '<=', $toUtc));
}
}
private function scheduleTimezone(): string
{
return (string) config('lottery.draw.timezone', 'UTC');
}
private function scheduleDateStartUtc(string $ymd): Carbon
{
return Carbon::createFromFormat('Y-m-d', $ymd, $this->scheduleTimezone())
->startOfDay()
->utc();
}
private function scheduleDateEndUtc(string $ymd): Carbon
{
return Carbon::createFromFormat('Y-m-d', $ymd, $this->scheduleTimezone())
->endOfDay()
->utc();
}
}